RFR: 8269638: Property methods, setters, and getters in printing API should be final [v3]

[Prasanta Sadhukhan]

On Wed, 14 Jul 2021 20:44:47 GMT, Phil Race <prr at openjdk.org> wrote:

>> - Make various setters and getters and properties final as needed
>> - Move documentation to the property so the setters and getters inherit it, with an exception for the special case of JobSettings.setPageRanges()
>> - Override toString() on the properties in JobSettings so it doesn't delegate to the JobSettings class.
>> - Add a manual test program just so you can see what toString() does. No pass or fail, just informative.
>> 
>> This will need a CSR but I won't create that until the review is done.
>
> Phil Race has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8269638: Property methods, setters, and getters in printing API should be final

modules/javafx.graphics/src/main/java/javafx/print/PrinterJob.java line 226:

> 224:      * Setting a null value for printer will install the default printer.
> 225:      * Setting the current printer has no effect.
> 226:      * @return the <code>Printer</code> for this job

If we are using {@code Printer} preferred pattern above for new addition, probably we should use here too, no?

tests/manual/printing/JobSettingsInfo.java line 45:

> 43: import javafx.scene.Scene;
> 44: import javafx.scene.control.TextArea;
> 45: import javafx.scene.layout.*;

One more place wildcard overlooked...Since we changed one case above, probably it can also be rectified..

-------------

PR: https://git.openjdk.java.net/jfx/pull/574