RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc

[Kevin Rushforth]

On Tue, 29 Jun 2021 03:07:11 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

> Fixed javadoc to indicate that onEndOfMedia is invoked each time when end of cycle is reached regardless if it is repeating or not.

Looks good with one suggested change.

modules/javafx.media/src/main/java/javafx/scene/media/MediaPlayer.java line 117:

> 115:  * {@link #onRepeatProperty onRepeat} property is invoked. If the stop time is
> 116:  * reached, then the event handler registered with the {@link #onEndOfMediaProperty onEndOfMedia}
> 117:  * property is invoked regardless if the cycle is to be repeated or not.

I recommend the following wording change:

`regardless if the cycle` --> `regardless of whether the cycle`

-------------

PR: https://git.openjdk.java.net/jfx/pull/552