RFR: 8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]

Alexander Matveev almatvee at openjdk.java.net
Wed Jun 30 00:15:28 UTC 2021


On Tue, 29 Jun 2021 22:55:50 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8268683: JavaFX MediaPlayer onEndOfMedia behaviour different from Javadoc [v2]
>
> modules/javafx.media/src/main/java/javafx/scene/media/MediaPlayer.java line 117:
> 
>> 115:  * {@link #onRepeatProperty onRepeat} property is invoked. If the stop time is
>> 116:  * reached, then the event handler registered with the {@link #onEndOfMediaProperty onEndOfMedia}
>> 117:  * property is invoked regardless if the cycle is to be repeated or not.
> 
> I recommend the following wording change:
> 
> `regardless if the cycle` --> `regardless of whether the cycle`

Fixed.

-------------

PR: https://git.openjdk.java.net/jfx/pull/552


More information about the openjfx-dev mailing list