RFR: 8263322: Deadlock when calling Application.launch in the FXThread after Platform.startup [v3]

Kevin Rushforth kcr at openjdk.java.net
Wed Mar 10 22:06:09 UTC 2021


On Wed, 10 Mar 2021 21:54:32 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing deadlock when calling Application.launch in the FXThread after Platform.startup
>
> Florian Kirmaier has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - JDK-8263322
>    removed unused imports, added missing change
>  - JDK-8263322
>    Updated the unit-test so they match the wanted behavior discussed in the PR
>  - JDK-8263322
>    Added the tests for both cases, when JavaFX was initialized with Application.launch and Platform.startup

modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java line 661:

> 659: 
> 660:         // Note, this method is called on the FX Application Thread
> 661:         PlatformImpl.startup(() -> startupLatch.countDown());

Glad to see this reverted. I was going to ask you why it was needed (it shouldn't be).

-------------

PR: https://git.openjdk.java.net/jfx/pull/421


More information about the openjfx-dev mailing list