RFR: 8263322: Deadlock when calling Application.launch in the FXThread after Platform.startup [v3]
Florian Kirmaier
fkirmaier at openjdk.java.net
Wed Mar 10 22:35:33 UTC 2021
On Wed, 10 Mar 2021 22:03:52 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Florian Kirmaier has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - JDK-8263322
>> removed unused imports, added missing change
>> - JDK-8263322
>> Updated the unit-test so they match the wanted behavior discussed in the PR
>> - JDK-8263322
>> Added the tests for both cases, when JavaFX was initialized with Application.launch and Platform.startup
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/application/LauncherImpl.java line 661:
>
>> 659:
>> 660: // Note, this method is called on the FX Application Thread
>> 661: PlatformImpl.startup(() -> startupLatch.countDown());
>
> Glad to see this reverted. I was going to ask you why it was needed (it shouldn't be).
It was added, because I thought it shouldn't be allowed to call Application.launch after Platform.startup.
-------------
PR: https://git.openjdk.java.net/jfx/pull/421
More information about the openjfx-dev
mailing list