RFR: 8258777: SkinBase: add api to un-/register invalidation-/listChange listeners [v2]

[Kevin Rushforth]

On Tue, 23 Mar 2021 15:18:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> wondering about the sequence of next steps: should I create the csr before or after (partial) review of this? Doing before feels like expecting duplicate work (whenever doc changes are required, I'll have to change the code in the pr and the csr draft as well, I assume). If that's the way, I'll go it, naturally :)
>
> I'll review the API changes in the next day or so. Then you can update the CSR and move to Proposed. I'll also ask Ambarish to be the second reviewer on this.

The API looks good to me, so go ahead and create a Draft CSR (go to your JBS issue and select "More --> Create CSR"). I don't think it will change much, if any, so you won't be duplicating work. Since you are adding new methods to an existing class, you can use the format from [JDK-8259868](https://bugs.openjdk.java.net/browse/JDK-8259868) for the Specification section, just listing the new methods and their API docs, rather than diffs, which would be needed if changing existing javadoc comments.

-------------

PR: https://git.openjdk.java.net/jfx/pull/409