RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

[Nir Lisker]

On Tue, 25 May 2021 14:35:14 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 142:
> 
>> 140: 
>> 141:     /**
>> 142:      * The angle of the spotlight's inner cone. Surfaces whose angle to the light's origin is less than this angle
> 
> angle of a cone is angle between the two sides of cone or the total angle of cone. Here we are referring to an angle between the Light's direction vector and any side of cone. which would be half of the angle of a cone.
> So should we mention it here ? 
> 1. Half of the inner cone angle Or
> 2. Angle between the direction vector of light and edge/side of cone.
> 
> Am I over thinking here ?
> 
> Or we should not describe the behavior in terms of angle but mention it in terms of location/distance of a point. If point is inside the cone or outside the cone, distance of the point from the centre of cone.

I think that it's simply best to refer the reader to the image in the class doc.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334