RFR: 8234920: Add SpotLight to the selection of 3D light types [v15]

[Nir Lisker]

On Tue, 25 May 2021 14:40:28 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update documentation
>
> modules/javafx.graphics/src/main/java/javafx/scene/SpotLight.java line 171:
> 
>> 169:      * The angle of the spotlight's outer cone. Surfaces whose angle to the light's origin is greater than this angle
>> 170:      * receive no light. At smaller angles, the light intensity starts to increase. The valid range is
>> 171:      * {@code innerAngle <= outerAngle <= 180}; values outside of this range can produce unexpected results.
> 
> Similar to innerAngle comment.

I made a similar change, but there is a minor caveat I ignored when writing that the point receives no light. The attenuation factor (by distance) can be infinite if we set all the factors to 0. This will give an intensity of 0 * infinity, so depending on the implementation, the point can receive light even outside of the cone. I think we can ignore this in the docs.

-------------

PR: https://git.openjdk.java.net/jfx/pull/334