RFR: 8274274: Update JUnit to version 5.8.1 [v7]

Kevin Rushforth kcr at openjdk.java.net
Mon Nov 22 12:56:10 UTC 2021


On Sun, 21 Nov 2021 21:50:36 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests still work.  Also added a single JUnit 5 tests, and confirmed it works.
>> 
>> I've updated the Eclipse project file for the base module only.
>
> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Add trivial assert to JUnit5Test
>  - Add explicit dependencies in build.gradle

Looks good with one comment inline.

modules/javafx.base/src/test/java/test/JUnit5Test.java line 28:

> 26: package test;
> 27: 
> 28: import static org.junit.Assert.assertNotNull;

For JUnit 5, shouldn't this be `org.junit.jupiter.api.Assertions.assertNotNull`?

-------------

PR: https://git.openjdk.java.net/jfx/pull/633


More information about the openjfx-dev mailing list