RFR: 8274274: Update JUnit to version 5.8.1 [v7]

John Hendrikx jhendrikx at openjdk.java.net
Mon Nov 22 13:36:42 UTC 2021


On Mon, 22 Nov 2021 12:52:10 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Add trivial assert to JUnit5Test
>>  - Add explicit dependencies in build.gradle
>
> modules/javafx.base/src/test/java/test/JUnit5Test.java line 28:
> 
>> 26: package test;
>> 27: 
>> 28: import static org.junit.Assert.assertNotNull;
> 
> For JUnit 5, shouldn't this be `org.junit.jupiter.api.Assertions.assertNotNull`?

Sorry, I totally missed that.  Although you can mix these without ill effect, we should move towards the `jupiter` annotations if we ever want to get to the point where JUnit 4 can be phased out.

-------------

PR: https://git.openjdk.java.net/jfx/pull/633


More information about the openjfx-dev mailing list