RFR: 8274274: Update JUnit to version 5.8.1 [v7]
Kevin Rushforth
kcr at openjdk.java.net
Mon Nov 22 13:30:09 UTC 2021
On Sun, 21 Nov 2021 21:50:36 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:
>> I've added JUnit 5 as a test dependency and made sure that the JUnit 4 tests still work. Also added a single JUnit 5 tests, and confirmed it works.
>>
>> I've updated the Eclipse project file for the base module only.
>
> John Hendrikx has updated the pull request incrementally with two additional commits since the last revision:
>
> - Add trivial assert to JUnit5Test
> - Add explicit dependencies in build.gradle
I was looking for places where JUnit 4.8.2 was still being referenced and found two more places that should be changed:
1. [`buildSrc/build.gradle`](https://github.com/openjdk/jfx/blob/d06d657007c3af86ba2ff908b546cae18e775bfb/buildSrc/build.gradle#L77) depends on JUnit 4.8.2 -- this should be changed to JUnit 4.13.2 (and you will need to add hamcrest)
2. Once the above is fixed, you should be able to remove the JUnit 4.8.2 artifacts from [`gradle/verification-metadata.xml`](https://github.com/openjdk/jfx/blob/d06d657007c3af86ba2ff908b546cae18e775bfb/gradle/verification-metadata.xml#L122)
-------------
PR: https://git.openjdk.java.net/jfx/pull/633
More information about the openjfx-dev
mailing list