RFR: 8272870: Add convenience factory methods for border and background [v2]
Ambarish Rapte
arapte at openjdk.java.net
Thu Sep 2 13:13:39 UTC 2021
On Fri, 27 Aug 2021 17:40:48 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
>> Added convenience factory factory methods for Background and Border.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>
> Corrected comment tags
Provided few suggestions for doc.
modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java line 357:
> 355:
> 356: /**
> 357: * A convenience factory method for creating a background with a single {@code Paint}. The background will use the
Suggestion to rephrase as:
`A convenience factory method for creating a Background by specifying only the {@code Paint} for BackgroundFill`
modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java line 361:
> 359: *
> 360: * @implSpec This call is equivalent to {@code new Background(new BackgroundFill(fill, null, null));}.
> 361: * @param fill the fill of the background
`@param fill Any Paint. If null, the value Color.TRANSPARENT is used.`
Picked from BackgroundFill constructor's doc
modules/javafx.graphics/src/main/java/javafx/scene/layout/Border.java line 393:
> 391:
> 392: /**
> 393: * A convenience factory method for creating a solid border with a single {@code Paint}. The border will use the
Suggestion to rephrase as:
`A convenience factory method for creating a solid Border by specifying only the {@code Paint} for BorderStroke.`
modules/javafx.graphics/src/main/java/javafx/scene/layout/Border.java line 398:
> 396: * @implSpec
> 397: * This call is equivalent to {@code new Border(new BorderStroke(stroke, BorderStrokeStyle.SOLID, null, null));}.
> 398: * @param stroke the stroke of the border
`@param stroke The stroke to use for all sides. If {@code null}, defaults to {@code Color.BLACK}.`
Picked from BorderStroke doc
-------------
Changes requested by arapte (Reviewer).
PR: https://git.openjdk.java.net/jfx/pull/610
More information about the openjfx-dev
mailing list