RFR: 8272870: Add convenience factory methods for border and background [v2]
Ambarish Rapte
arapte at openjdk.java.net
Thu Sep 2 13:13:41 UTC 2021
On Fri, 27 Aug 2021 14:13:01 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Corrected comment tags
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Background.java line 364:
>
>> 362: * {@code new Background(new BackgroundFill(fill, null, null));}
>> 363: * @param fill the fill of the background
>> 364: * @return a new background of the given fill
>
> Need to add `@since 18`
`@return a new background of the given fill` -> `@return a new Background with specified fill`
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Border.java line 400:
>
>> 398: * {@code new Border(new BorderStroke(stroke, BorderStrokeStyle.SOLID, null, null));}
>> 399: * @param stroke the stroke of the border
>> 400: * @return a new border of the given stroke
>
> Same comments about the javadoc as above.
`@return a new border of the given stroke` -> `@return a new Border with the specified stroke`
-------------
PR: https://git.openjdk.java.net/jfx/pull/610
More information about the openjfx-dev
mailing list