RFR: 8290844: Add Skin.install() method

Andy Goryachev angorya at openjdk.org
Mon Aug 8 20:37:50 UTC 2022


On Fri, 22 Jul 2022 19:22:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> - added Skin.install()
> - javadoc changes for Skinnable.setSkin(Skin)
> 
> no code changes for Skinnable.setSkin(Skin) yet.

All good points, many thanks!
Fixed the setSkin(), changed the javadoc for setSkin() to indicate that this method *might* throw an IAE.

modules/javafx.controls/src/main/java/javafx/scene/control/PopupControl.java line 205:

> 203:         if(value != null) {
> 204:             if(value.getSkinnable() != this) {
> 205:                 throw new IllegalArgumentException("There must be 1:1 relationship between Skin and Skinnable");

this check always fails in case of PopupControl.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list