RFR: 8290844: Add Skin.install() method [v2]

[Phil Race]

On Thu, 11 Aug 2022 16:24:19 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> In this case, a IllegalArgumentException is not a checked exception (not a part of general contract).
>> 
>> Just like in TextInputControl.getText(int, int) : 457, for example.
>
> Whether or not it is a checked exception, we should document exceptions that are thrown with `@throws`.
> 
> In this case, I see that it says the exception "might" be thrown, so if we add an `@throws` (which seems a good idea), it would need to describe the conditions under which it might be thrown.

Yes, even if there are some places in FX that don't, the expectation is that it is listed in an @throws.
There are hundreds of examples of this in the JDK.
Also whenever you have the name of a class (etc) in the comment use {@code IllegalArgumentException)

-------------

PR: https://git.openjdk.org/jfx/pull/845