RFR: 8290844: Add Skin.install() method [v2]

Andy Goryachev angorya at openjdk.org
Thu Aug 11 16:36:35 UTC 2022


On Thu, 11 Aug 2022 16:30:48 GMT, Phil Race <prr at openjdk.org> wrote:

>> Whether or not it is a checked exception, we should document exceptions that are thrown with `@throws`.
>> 
>> In this case, I see that it says the exception "might" be thrown, so if we add an `@throws` (which seems a good idea), it would need to describe the conditions under which it might be thrown.
>
> Yes, even if there are some places in FX that don't, the expectation is that it is listed in an @throws.
> There are hundreds of examples of this in the JDK.
> Also whenever you have the name of a class (etc) in the comment use {@code IllegalArgumentException)

thank you all, will fix.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list