RFR: 8290844: Add Skin.install() method [v4]

Jeanette Winzenburg fastegal at openjdk.org
Wed Aug 24 16:10:34 UTC 2022


On Fri, 12 Aug 2022 18:15:37 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> - added Skin.install()
>> - javadoc changes for Skinnable.setSkin(Skin)
>> 
>> no code changes for Skinnable.setSkin(Skin) yet.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8290844: review comments

ahh .. at least I seem to see now where we talked past each other: 

         YY userYY;
         // install
         userYY = control.getYY();
         control.setYY(myYY);

         // dispose: reset to previous user installed YY
         if (getSkinnable().getYY() == myYY) getSkinnable().setYY(userYY);

not sure if that's anything we want to do, and also not  a pattern currently used anywhere in our skins 

Anyway, off for today, need food and family :)

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list