RFR: 8290844: Add Skin.install() method [v4]
Andy Goryachev
angorya at openjdk.org
Wed Aug 31 15:22:22 UTC 2022
On Wed, 24 Aug 2022 16:08:32 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8290844: review comments
>
> ahh .. at least I seem to see now where we talked past each other:
>
> YY userYY;
> // install
> userYY = control.getYY();
> control.setYY(myYY);
>
> // dispose: reset to previous user installed YY
> if (getSkinnable().getYY() == myYY) getSkinnable().setYY(userYY);
>
> not sure if that's anything we want to do, and also not a pattern currently used anywhere in our skins
>
> Anyway, off for today, need food and family :)
Dear @kleopatra :
Are we in agreement that the issue with setting a field (that cannot be reimplemented via add/remove listener) cannot be fixed without adding install() method, or should I provide a clearer example?
I'd like to move this PR forward, if possible.
Thank you.
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list