RFR: 8295531: ComboBoxBaseSkin: memory leak when changing skin [v5]

[Ajit Ghaisas]

On Fri, 2 Dec 2022 17:35:05 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> as determined by SkinMemoryLeakTest (remove line 166) and a leak tester
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>> 
>> Affected skins:
>> - ColorPicker
>> - DatePicker
>> - ComboBox
>> 
>> caused by:
>> - out-of-order modification of the control property (skin.install)
>> - adding skin nodes and not removing them in dispose()
>> - adding listeners and not removing them in dispose()
>> 
>> NOTE: the fix will require not only ListenerHelper [JDK-8294809](https://bugs.openjdk.org/browse/JDK-8294809) but also Skin.install() [JDK-8290844](https://bugs.openjdk.org/browse/JDK-8290844) changes.
>
> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 56 commits:
> 
>  - Merge remote-tracking branch 'origin/master' into
>    8295531.color.picker.skin
>  - 8295531: trying to avoid merge conflicts in the future
>  - Merge remote-tracking branch 'origin/master' into
>    8295531.color.picker.skin
>  - Merge remote-tracking branch 'origin/master' into
>    8295531.color.picker.skin
>  - Merge remote-tracking branch 'origin/master' into
>    8295531.color.picker.skin
>  - Merge remote-tracking branch 'origin/master' into 8295531.color.picker.skin
>  - 8295531: whitespace
>  - 8295531: selection model leak
>  - Merge branch '8294809.listener.helper' into 8295531.color.picker.skin
>  - 8294809: generics
>  - ... and 46 more: https://git.openjdk.org/jfx/compare/e64e1292...06cf1dfc

Fix Looks good to me!

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/922