RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v5]

[Kevin Rushforth]

On Wed, 7 Dec 2022 17:21:48 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Thanks for the explanation. I don't have a better suggestion than what you propose, so let's proceed. It might be good to check whether the property is bound and skip setting it in the unlikely event that it is (save/restore the binding might be tricky and not something I can recall ever doing).
>
> Perhaps we can introduce another property - either public or internal to suppress consumption of auto-hiding events?
> 
> The other aspect of this problem, as we discussed earlier, is that, in my opinion, the tooltips should really be transparent to mouse clicks.  We do have this problem in Swing - if the tool tip overlaps a button , the user needs two clicks - first dismisses the tooltip and the other depresses the button.  That will be a behavioral change.
> 
> What do you think?

Whatever we decide for this particular bug fix, I agree that we should reexamine whether tooltips should be transparent to mouse clicks by default.

As for this bug fix, I wouldn't want to introduce a new public property, so that leaves either the currently proposed solution of saving / restoring the existing public property, or adding an internal property. If this new internal property could be somehow limited to Tooltip, that might be OK; otherwise it could be pretty intrusive.

-------------

PR: https://git.openjdk.org/jfx/pull/965