RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v5]
Karthik P K
kpk at openjdk.org
Thu Dec 8 10:40:15 UTC 2022
On Thu, 8 Dec 2022 03:10:06 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> Perhaps we can introduce another property - either public or internal to suppress consumption of auto-hiding events?
>>
>> The other aspect of this problem, as we discussed earlier, is that, in my opinion, the tooltips should really be transparent to mouse clicks. We do have this problem in Swing - if the tool tip overlaps a button , the user needs two clicks - first dismisses the tooltip and the other depresses the button. That will be a behavioral change.
>>
>> What do you think?
>
> Whatever we decide for this particular bug fix, I agree that we should reexamine whether tooltips should be transparent to mouse clicks by default.
>
> As for this bug fix, I wouldn't want to introduce a new public property, so that leaves either the currently proposed solution of saving / restoring the existing public property, or adding an internal property. If this new internal property could be somehow limited to Tooltip, that might be OK; otherwise it could be pretty intrusive.
Updated code to check whether `consumeAutoHidingEventsProperty` is bound and skip the property value change in mouse entered and exited event handlers.
Since we need to recheck the behavior of tooltip, I would like to keep the above proposed solution for the time being.
-------------
PR: https://git.openjdk.org/jfx/pull/965
More information about the openjfx-dev
mailing list