RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

Andy Goryachev angorya at openjdk.org
Fri Dec 9 21:53:31 UTC 2022


On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K <kpk at openjdk.org> wrote:

>> Cause: When slider is dragged for first time after tooltip appears, setOnMousePressed event was not invoked, hence dragStart was null in the subsequently invoked event handler (setOnMouseDragged).
>> 
>> Fix: Initialized dragStart in initialize method.
>> 
>> Test: Added system test to validate the fix.
>> 
>> Note: Initializing dragStart in layoutChildren method as suggested in the bug was causing side effects. Hence initialized dragStart in initialize method.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add check whether consumeAutoHidingEventsProperty is bound

lgtm

-------------

Marked as reviewed by angorya (Committer).

PR: https://git.openjdk.org/jfx/pull/965


More information about the openjfx-dev mailing list