RFR: 8190411: NPE in SliderSkin:140 if Slider.Tooltip.autohide is true [v6]

Karthik P K kpk at openjdk.org
Mon Dec 12 05:56:59 UTC 2022


On Sat, 10 Dec 2022 15:42:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SliderSkin.java line 410:
>> 
>>> 408:         thumb.setOnMouseExited(me -> {
>>> 409:             Tooltip t = getSkinnable().getTooltip();
>>> 410:             if (t != null && t.isAutoHide() && !t.consumeAutoHidingEventsProperty().isBound()) {
>> 
>> I still think a second property or a boolean might be better.  What if the app code binds autoHidingEventsProperty after onMouseEntered?  I know this is highly unlikely, but there is a potential.
>> 
>> At the same time, I  think we should proceed with this fix as it addresses a problem which occurs always.
>
> Agreed. Let's file a follow-on bug to consider the larger question of whether we should change the default value of `consumeAutoHidingEventsProperty` for Tooltip, so that they will not consume auto-hiding events by default.

I have filed [JDK-8298529](https://bugs.openjdk.org/browse/JDK-8298529) for this.

-------------

PR: https://git.openjdk.org/jfx/pull/965


More information about the openjfx-dev mailing list