RFR: 8252863: Spinner keeps spinning if removed from Scene [v2]

Karthik P K kpk at openjdk.org
Mon Dec 19 06:53:54 UTC 2022


On Sat, 17 Dec 2022 19:55:11 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use ListenerHelper for sceneProperty
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/SpinnerSkin.java line 258:
> 
>> 256:             behavior.stopSpinning();
>> 257:         });
>> 258: 
> 
> minor: could we get rid of this extra newline?

Yes, this can be removed. Since an empty line was there before I had kept it as it is.

-------------

PR: https://git.openjdk.org/jfx/pull/976


More information about the openjfx-dev mailing list