RFR: 8297554: Remove Scene.KeyHandler [v3]

[Kevin Rushforth]

On Tue, 20 Dec 2022 16:03:23 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
>> 
>>  - Merge branch 'master' into fixes/keyhandler-refactor
>>  - review changes
>>  - Removed KeyHandler
>
> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 2279:
> 
>> 2277:     }
>> 2278: 
>> 2279:     private void setFocusOwner(Node node, boolean focusVisible) {
> 
> The earlier method `setFocusVisible()` is now merged into this method `setFocusOwner()`. and also the call to this method from `requestFocus()` is changed.
> That seems Ok to me, But would like a second pair of eye on it.

It took me a minute to see what he did, but it does look equivalent. The calls to this method from line 369 and line 2197 will hit the case on lines 2301-2307 if the node is the current focus owner, which will set the focus visible property as it did before.

-------------

PR: https://git.openjdk.org/jfx/pull/962