[jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

Kevin Rushforth kcr at openjdk.java.net
Fri Feb 4 22:07:15 UTC 2022


On Fri, 4 Feb 2022 18:26:57 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> Now that the standard concrete light types were added, there is an opportunity to rearrange and rewrite some of the class docs. Here is a summary of the changes:
>> 
>> * Moved the explanations of attenuation and direction up to `LightBase` since different light types share characteristics. `LightBase` now contains a summary of its subtypes and all the explanations of the properties/characteristics of the lights divided into sections: Color, Scope, Direction, Attenuation.
>> * Each light type links to the relevant section in `LightBase` when it mentioned the properties it has.
>> * Added examples of real-world applications for each light type.
>> * Consolidated the writing style for all the subclasses.
>
> Nir Lisker has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Changed description of ambient light

LGTM. I like your updated AmbientLight description.

-------------

Marked as reviewed by kcr (Lead).

PR: https://git.openjdk.java.net/jfx/pull/717


More information about the openjfx-dev mailing list