[jfx18] RFR: 8279345: Realign class docs of LightBase and subclasses [v5]

[Nir Lisker]

On Thu, 27 Jan 2022 19:01:32 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> I think the description should focus on the meaning of the respective term in the lighting equation, and not on a non-technical analogy. In this case, the analogy is a bit misleading on several aspects, including the fact that ambient lighting is not dependent on an area being enclosed. Here's a suggestion:
>> 
>> Ambient lights add a constant term to the amount of light reflected by each point on
>> the surface of an object, thereby increasing the brightness of the object uniformly and
>> independently of the orientation of its surfaces. It is often used to represent the base
>> amount of illumination in a scene.
>
> I think the key aspects of an Ambient light are that: the light seems to come from all directions (and thus has no position or direction), and that it illuminates objects independently of the position or orientation of the object.
> 
> I don't have a problem with also giving a real-world analogy if one can be found that makes it easier to understand without causing confusion.

I tried to unify some of the points that were brought up. See if you would like more changes.

-------------

PR: https://git.openjdk.java.net/jfx/pull/717