RFR: 8289389: Fix warnings: type should also implement hashCode() since it overrides Object.equals()

Kevin Rushforth kcr at openjdk.org
Fri Jul 8 21:46:51 UTC 2022


On Fri, 8 Jul 2022 19:46:20 GMT, Andy Goryachev <duke at openjdk.org> wrote:

> - added missing hashCode() methods

This is not a complete review, just one thing I spotted quickly.

modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 2329:

> 2327:             return 0;
> 2328:         }
> 2329:         return location.hashCode();

Shouldn't this be: `location.toExternalForm().hashCode()`?

-------------

PR: https://git.openjdk.org/jfx/pull/821


More information about the openjfx-dev mailing list