RFR: 8289394: Fix warnings: Unlikely argument type

Kevin Rushforth kcr at openjdk.org
Mon Jul 18 17:11:14 UTC 2022


On Mon, 18 Jul 2022 17:01:35 GMT, Andy Goryachev <duke at openjdk.org> wrote:

>> modules/javafx.graphics/src/test/java/test/javafx/css/Node_cssStyleMap_Test.java line 80:
>> 
>>> 78:      * @param map
>>> 79:      * @param decls
>>> 80:      */
>> 
>> This is unrelated to the fix, so it seems best to revert this.
>
> I insist.  Whenever method signature cannot ensure type safety, the next guard, or at least some human-readable safety check should be a (javadoc) comment, wouldn't you agree?

It's a private method, so doesn't really matter much, but I definitely see your point.

-------------

PR: https://git.openjdk.org/jfx/pull/823


More information about the openjfx-dev mailing list