RFR: 8289394: Fix warnings: Unlikely argument type [v2]

Andy Goryachev duke at openjdk.org
Mon Jul 18 21:50:00 UTC 2022


> Fixes "Unlikely argument type" warning generated by the latest Eclipse IDE.
> 
> This warning should be reclassified as an error, as it catches bugs missed by javac.  In this case, the following places seem to contain bugs:
> - apps/samples/3DViewer/src/main/java/com/javafx/experiments/jfx3dviewer/TimelineController.java
> - modules/javafx.graphics/src/main/java/com/sun/glass/ui/monocle/GetEvent.java
> 
> The fixes include:
> - using objects of the right type
> - adding @SuppressWarnings("unlikely-arg-type") in places where intended (e.g. assertFalse)
> 
> There was an earlier discussion about using IDE-specific @SuppressWarnings in the code.  While I might disagree (I think it is ok to use IDE-specific @SuppressWarnings), the tests can be reworked to avoid @SuppressWarnings.  Please let me know.  Thanks!

Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:

 - 8289394: review comments
 - Merge remote-tracking branch 'origin/master' into 8289394.unlikely
 - 8289394: fixed whitespace
 - 8289394: fixed unlikely argument type warning

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/823/files
  - new: https://git.openjdk.org/jfx/pull/823/files/34ea08ea..7e97d635

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=823&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=823&range=00-01

  Stats: 3294 lines in 69 files changed: 2992 ins; 59 del; 243 mod
  Patch: https://git.openjdk.org/jfx/pull/823.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/823/head:pull/823

PR: https://git.openjdk.org/jfx/pull/823


More information about the openjfx-dev mailing list