RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

[Nir Lisker]

On Fri, 18 Mar 2022 09:32:18 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.base/src/main/java/javafx/beans/value/FlatMappedBinding.java line 68:
>> 
>>> 66:         };
>>> 67:     }
>>> 68: }
>> 
>> Several files are missing newlines after the last closing brace. Do we enforce this?
>> 
>> Also, if there's a newline after the first line of a class declaration, shouldn't there also be a newline before the last closing brace?
>
> Let me add those new lines at the end of files (everywhere) as Github is also flagging it with an ugly red marker.  I tend to unconsciously remove them myself on longer files as it looks weird in editors to have an unused line at the bottom.
> 
> As for the newline before the last closing brace, that doesn't seem to be done a lot in the current code base.  I've added those newlines at the top as it seems fairly consistent in the code base, although I'm not a fan as I use empty lines only to separate things when there is no clear separation already (like an opening brace).

I don't think jcheck checks for newlines anywhere. Usually the style that I see is a newline after the definition of the class and at the end of the file (sometimes), but not before the last closing brace.

-------------

PR: https://git.openjdk.java.net/jfx/pull/675