RFR: 8274771: Map, FlatMap and OrElse fluent bindings for ObservableValue [v10]

[Michael Strauß]

On Fri, 18 Mar 2022 10:17:01 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.base/src/main/java/javafx/beans/value/ObservableValue.java line 197:
>> 
>>> 195:     /**
>>> 196:      * Creates an {@code ObservableValue} that holds the value of an {@code ObservableValue}
>>> 197:      * resulting from applying a mapping on this {@code ObservableValue}'s value. The result
>> 
>> While technically correct, I think the first sentence should focus more on the purpose of this method.
>> 
>> How about something like this:
>> `Creates a new {@code ObservableValue} that holds the value of a nested {@code ObservableValue} by applying a mapping function to extract the nested {@code ObservableValue}.`
>> 
>> That's not as precise, but it makes the purpose much more clear.
>
> I've changed this to use your wording as I think it does read much better.
> 
> Perhaps also possible:
> 
>       Creates a new {@code ObservableValue} that holds the value of a nested {@code ObservableValue} supplied
>       by the given mapping function.
> 
> ?

Both seem fine, I don't have any preference over one or the other.

-------------

PR: https://git.openjdk.java.net/jfx/pull/675