RFR: 8088420: JavaFX WebView memory leak via EventListener [v5]

Jay Bhaskar jbhaskar at openjdk.java.net
Thu May 26 06:58:04 UTC 2022


On Wed, 25 May 2022 14:57:13 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Jay Bhaskar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments applied
>
> modules/javafx.web/src/main/native/Source/WebCore/bindings/java/EventListenerManager.cpp line 109:
> 
>> 107:             isReferringToOtherListener = false;
>> 108:         else
>> 109:             isReferringToOtherListener = true;
> 
> I have not looked very clearly, but here is a question: Should the loop break when `if` condition passes ?

No, it should not , if condition pass means there is ref count of 1 for the particular ref object. but we have to look for all other objects too , to check whether a ref counted object might be referred by other Dom Window.

-------------

PR: https://git.openjdk.java.net/jfx/pull/799


More information about the openjfx-dev mailing list