RFR: 8256397: MultipleSelectionModel throws IndexOutOfBoundException [v5]

[Ajit Ghaisas]

On Thu, 14 Jul 2022 08:05:25 GMT, Florian Kirmaier <fkirmaier at openjdk.org> wrote:

>> Fixing IndexOutOfBoundsException in the MultipleSelectionModelBase and added a unit-test for it.
>> ticket: https://bugs.openjdk.java.net/browse/JDK-8256397
>> run test: `./gradlew --continue -PFULL_TEST=true controls:test --tests "*MultipleSelectionModelImplTest*"`
>
> Florian Kirmaier has updated the pull request incrementally with one additional commit since the last revision:
> 
>   JDK_8256397
>   Fixed more issues with the multiple selection model change events, and verified them with more unit-tests.

The fix looks good.
I have identified minor spacing issues.

modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 721:

> 719:             size = -1;
> 720:             bitset.set(index);
> 721:             if(index <= lastGetValue) reset();

There should be a space between `if` and `(`

modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 744:

> 742:             if (isSet) {
> 743:                 bitset.set(index, end, isSet);
> 744:                 if(index <= lastGetValue) reset();

There should be a space between `if` and `(`

modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 751:

> 749:                 // TODO handle remove
> 750:                 bitset.set(index, end, isSet);
> 751:                 if(index <= lastGetValue) reset();

There should be a space between `if` and `(`

modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java line 827:

> 825:             size = -1;
> 826:             bitset.clear(index);
> 827:             if(index <= lastGetValue) reset();

There should be a space between `if` and `(`

-------------

PR: https://git.openjdk.org/jfx/pull/353