RFR: JDK-8297332: Remove easy warnings in javafx.base

[John Hendrikx]

On Mon, 21 Nov 2022 21:06:53 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> let's create a followup ticket - the messed up statements in Disposer and especially in PrismFontFactory:1401 are worrying.
>> 
>> cc: @prrace
>
> All of the bugs in the list are not in the base module. We are slicing the work both per warning types and per modules/packages. Right now we are doing only trivial fixes in `base`.

> but the ticket specifies (javafx.)base, right?

Yes, so only the warnings listed and only in javafx.base.  Rawtype/unchecked warnings, and things like empty control-flow statements, unused variables/fields/types and dead code will be fixed in other tickets.  It's possible some of these won't be fixed if it is an unusual but harmless pattern. Generally it's better to fix or slightly rewrite these though as it makes things easier when there are no exceptions (ie. when enforcing things later).

-------------

PR: https://git.openjdk.org/jfx/pull/957