RFR: JDK-8297332: Remove easy warnings in javafx.base

Kevin Rushforth kcr at openjdk.org
Mon Nov 21 22:38:37 UTC 2022


On Mon, 21 Nov 2022 20:49:07 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> but the ticket specifies (javafx.)base, right?
>
> let's create a followup ticket - the messed up statements in Disposer and especially in PrismFontFactory:1401 are worrying.
> 
> cc: @prrace

@andy-goryachev-oracle The ones in the various `Disposer` classes and `PrismFontFactory` are functionally correct, but use an anti-pattern. The block really is intentionally empty, but the better pattern for this is to use `{}` rather than a `;` since the latter looks like you might have made a mistake.

-------------

PR: https://git.openjdk.org/jfx/pull/957


More information about the openjfx-dev mailing list