RFR: JDK-8297413: Remove easy warnings in javafx.graphics

Kevin Rushforth kcr at openjdk.org
Tue Nov 22 22:32:30 UTC 2022


On Tue, 22 Nov 2022 22:18:54 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> If it aids readability, I don't see it as unnecessary. In this case, since the types of all of the variables are not known, you could certainly argue it doesn't matter much -- you need to look at the types to reason about what it does.
>
> I agree.  The problem is that we will not be able to enable the warning in IDE, or it has to be @suppressed.
> 
> So the choice is either fix the code and enable warning, or keep the code as is and disable the warning.

I don't see it as a useful warning. The code isn't necessarily better without, and can be less clear. I think this might argue for asking Eclipse users to disable this warning in the IDE.

-------------

PR: https://git.openjdk.org/jfx/pull/960


More information about the openjfx-dev mailing list