RFR: 8295796: ScrollPaneSkin: memory leak when changing skin

[Ajit Ghaisas]

On Fri, 21 Oct 2022 19:01:54 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> as determined by SkinMemoryLeakTest (remove line 174) and a leak tester 
> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
> 
> caused by:
> - adding and not removing listeners
> - adding and not removing event handlers/filters
> 
> NOTE:
> this fix requires JDK-8295242 scroll bar fixes, as well as JDK-8294809 ListenerHelper

The fix looks good.
I have a cleanup comment on the Test.

modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java line 173:

> 171:                 Pagination.class,
> 172:                 PasswordField.class,
> 173:                 //ScrollBar.class,

We can remove these lines instead of commenting them out.

-------------

Marked as reviewed by aghaisas (Reviewer).

PR: https://git.openjdk.org/jfx/pull/928