RFR: 8295796: ScrollPaneSkin: memory leak when changing skin

[Andy Goryachev]

On Tue, 29 Nov 2022 11:10:39 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:

>> as determined by SkinMemoryLeakTest (remove line 174) and a leak tester 
>> https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java
>> 
>> caused by:
>> - adding and not removing listeners
>> - adding and not removing event handlers/filters
>> 
>> NOTE:
>> this fix requires JDK-8295242 scroll bar fixes, as well as JDK-8294809 ListenerHelper
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/SkinMemoryLeakTest.java line 173:
> 
>> 171:                 Pagination.class,
>> 172:                 PasswordField.class,
>> 173:                 //ScrollBar.class,
> 
> We can remove these lines instead of commenting them out.

@aghaisas : 
will clean up this area once the last PR is integrated, otherwise we'll have constant merge conflicts here (every skin memory leak PR touches this)

-------------

PR: https://git.openjdk.org/jfx/pull/928