RFR: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest [v6]

Kevin Rushforth kcr at openjdk.org
Tue Nov 29 14:04:30 UTC 2022


On Tue, 29 Nov 2022 13:36:14 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

>> The change moves Locale setting in the test to `@BeforeClass` and `@AfterClass` calls. `@BeforeClass` method call stores current default VM locale and applies Locale.US, while `@AfterClass` method restores old VM locale after all tests are completed.
>> 
>> I tested it both on Mac and Windows, in both cases Locale is changed, restored properly and tests pass.
>
> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove unnecessary InvalidParameterException import

Marked as reviewed by kcr (Lead).

-------------

PR: https://git.openjdk.org/jfx/pull/954


More information about the openjfx-dev mailing list