Integrated: 8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest

Lukasz Kostyra lkostyra at openjdk.org
Tue Nov 29 14:55:38 UTC 2022


On Thu, 17 Nov 2022 16:59:09 GMT, Lukasz Kostyra <lkostyra at openjdk.org> wrote:

> The change moves Locale setting in the test to `@BeforeClass` and `@AfterClass` calls. `@BeforeClass` method call stores current default VM locale and applies Locale.US, while `@AfterClass` method restores old VM locale after all tests are completed.
> 
> I tested it both on Mac and Windows, in both cases Locale is changed, restored properly and tests pass.

This pull request has now been integrated.

Changeset: 4ad85828
Author:    Lukasz Kostyra <lkostyra at openjdk.org>
Committer: Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/4ad85828868066781093131723f9f5214dca928e
Stats:     250 lines in 3 files changed: 189 ins; 21 del; 40 mod

8265828: [TestBug] Save and restore the default Locale in javafx.base unit test LocalDateTimeStringConverterTest

Reviewed-by: kcr

-------------

PR: https://git.openjdk.org/jfx/pull/954


More information about the openjfx-dev mailing list