RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v5]

Tue Nov 29 21:39:31 UTC 2022

On Wed, 23 Nov 2022 21:41:09 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> The `processEndElement` in the base class was an empty method that throws `IOException`.  By making it `abstract` the warning is avoided, but this means the call to `super` here is no longer relevant (it wasn't relevant anyway as the base method was empty).
>
> I think that we should refrain from making "structural" changes in this pass. Let's keep the warning on and deal with these later.

I see that this change has been reverted. That's good.

FWIW, I disagree with the original premise of removing it. The subclass shouldn't have to know or care that the superclass method is empty or not.

I looked through the current version, and no longer have any concerns about this PR. I'll let others formally review.

-------------

PR: https://git.openjdk.org/jfx/pull/958