RFR: JDK-8297412: Remove easy warnings in javafx.fxml, javafx.media, javafx.swing, javafx.swt and javafx.web [v5]

[Kevin Rushforth]

On Mon, 28 Nov 2022 17:04:17 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> - Remove unsupported/unnecessary SuppressWarning annotations
>> - Remove reduntant type specifications (use diamond operator)
>> - Remove unused or duplicate imports
>> - Remove unnecessary casts (type is already correct type or can be autoboxed)
>> - Remove unnecessary semi-colons (at end of class definitions, or just repeated ones)
>> - Remove redundant super interfaces (interface that is already inherited)
>> - Remove unused type parameters
>> - Remove declared checked exceptions that are never thrown
>> - Add missing `@Override` annotations
>
> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revert change of private class to abstract in FXMLLoader
>   
>   Exception is now documented instead

> As I go over the code in various places to look at suspicious changes, I find some rather peculiar pieces of code.
> ...
> Just food for thought about how dealing with these warnings can reveal not only immediate bugs, but also sketchy code that makes you raise an eyebrow.

That's an interesting observation. As you say, "food for thought". If done carefully in an area that we are intended to improve for other (functional) reasons, then it might be worth it in some cases. Probably not for most areas, though.

-------------

PR: https://git.openjdk.org/jfx/pull/958