RFR: JDK-8297414: Remove easy warnings in javafx.controls [v8]
Nir Lisker
nlisker at openjdk.org
Wed Nov 30 00:49:19 UTC 2022
On Tue, 29 Nov 2022 18:37:23 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:
>> interesting - there is technically no change, as `TableColumnBase` implements `EventTarget`.
>> @hjohn does javadoc produce a different result?
>
> I checked, and yes it does produce a different result:
>
> Current:
>
>
> public class TableColumn<S,T>
> extends TableColumnBase<S,T>
> implements EventTarget
>
>
> After proposed change:
>
>
> public class TableColumn<S,T>
> extends TableColumnBase<S,T>
>
>
> Additionally, the class file is different. The signature for the class stored in the class file has `implements EventTarget` before this change, and not after . I'm not saying it's incompatible, but it is out of scope for this sort of global cleanup.
How curious. I would have thought that the compiler would remove multiple inheritance paths and the classfile would be the same. As for the javadocs, it seems like the wrong behavior to me. I will try to ask on the mailing list if this is intentional.
I don't mind reverting it for this PR.
-------------
PR: https://git.openjdk.org/jfx/pull/959
More information about the openjfx-dev
mailing list