RFR: 8294589: MenuBarSkin: memory leak when changing skin

[Jeanette Winzenburg]

On Fri, 30 Sep 2022 16:05:57 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> after:
>> <img width="940" alt="Screen Shot 2022-09-30 at 09 01 36" src="https://user-images.githubusercontent.com/107069028/193310795-48b2a72d-aad7-4c36-81d8-740f302fccb7.png">
>
> See https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/apps/LeakTest.java

okay, not tested (so treat it as just a wild guess :) - there is this listener on the skinnable's sceneProperty: it's installed only when there's no scene and removed once the scene is set. Without showing, it looks like it's never removed (as it must!)

Unrelated: also look at your dispose: it's violating its contract (making SkinDisposeContractTest fail)

-------------

PR: https://git.openjdk.org/jfx/pull/906