RFR: 8290844: Add Skin.install() method [v9]

Kevin Rushforth kcr at openjdk.org
Sat Oct 8 15:46:25 UTC 2022


On Wed, 5 Oct 2022 11:50:23 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> I agree with @kevinrushforth , it's one of the cases when the method is public, but it should not be called by an application, only by its Control.
>> 
>> Perhaps we should further clarify this fact?
>
> Control is _our_ specific implementation - others might differ :) And not talking about application code but a possibly complete skinnable/skin controlling scheme. 
> 
> But I see your point - how can we clearly express that the complete dispose-install cycle should be in the hands of exactly one collaborator (whether a skinnable's property or somewhere else)?
> 
> The concrete cells have public methods that are marked as "expert api" - maybe we could do something similar here?

I'm not sure that we need to provide for other implementations of Skinnable/Skin. If we can figure out a good way to express the needed invariants in a more neutral way, that's OK, but I'd rather err on the side of clearly defining the requirements of our implementation of Skinnable/Skin.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list