RFR: 8290844: Add Skin.install() method [v15]

[Kevin Rushforth]

On Thu, 27 Oct 2022 18:21:53 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 28 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: review comments
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: review comments
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: javadoc
>>  - Merge remote-tracking branch 'origin/master' into 8290844.skin.install
>>  - 8290844: javadoc
>>  - Merge branch 'openjdk:master' into 8290844.skin.install
>>  - 8290844: unit tests
>>  - ... and 18 more: https://git.openjdk.org/jfx/compare/b3cfd555...3235d433
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTest.java line 816:
> 
>> 814:         SkinStub skin = new SkinStub(new ControlStub());
>> 815:         c.setSkin(skin);
>> 816:     }
> 
> Is Junit 5 availabe for this project?  If so I'd recommend writing:
> Suggestion:
> 
>     @Test
>     public void skinMustCorrespondToControl() {
>         SkinStub skin = new SkinStub(new ControlStub());
>         assertThrows(IllegalArgumentException.class, () -> c.setSkin(skin));
>     }

We don't want to mix JUnit 4 and JUnit 5 in the same file, and it seems out of scope to change this existing test class to use Junit5.

-------------

PR: https://git.openjdk.org/jfx/pull/845