RFR: 8290844: Add Skin.install() method [v15]

Andy Goryachev angorya at openjdk.org
Thu Oct 27 23:40:35 UTC 2022


On Thu, 27 Oct 2022 23:30:39 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTest.java line 816:
>> 
>>> 814:         SkinStub skin = new SkinStub(new ControlStub());
>>> 815:         c.setSkin(skin);
>>> 816:     }
>> 
>> Is Junit 5 availabe for this project?  If so I'd recommend writing:
>> Suggestion:
>> 
>>     @Test
>>     public void skinMustCorrespondToControl() {
>>         SkinStub skin = new SkinStub(new ControlStub());
>>         assertThrows(IllegalArgumentException.class, () -> c.setSkin(skin));
>>     }
>
> We don't want to mix JUnit 4 and JUnit 5 in the same file, and it seems out of scope to change this existing test class to use Junit5.

Are we mixing?  I believe the tests have been converted to JUnit5 some time ago, [JDK-8292678](https://bugs.openjdk.org/browse/JDK-8292678) at least in Eclipse.
I think this is a valid change.

-------------

PR: https://git.openjdk.org/jfx/pull/845


More information about the openjfx-dev mailing list