RFR: 8290844: Add Skin.install() method [v4]

[Andy Goryachev]

On Sat, 3 Sep 2022 10:14:53 GMT, Jeanette Winzenburg <fastegal at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8290844: review comments
>
> that's basically the problem we identified as not solvable by current api, though I would formulate slightly differently: there are two bugs in our current implementation, one in step 3 and one in step 6
> 
>     // bug in step 3: should be replacing the property only if not set be the user
>     if  (control.getInputMethodRequest() == USER1) { // no means to detect user vs. skin installed
>              // do nothing
>     }  else {
>             control.setInputMethodRequest(SKIN1);
>     }
> 
>     // bug in step 6: nulling unconditionally in dispose is wrong, should only do if installed by the skin
>     if (control.getInputMethodRequest() == SKIN1) control.setInputMethodRequest(null);
> 
> Yes: there is no way to differentiate USER1 from SKIN1 in step 5 without new API :) There are options besides a new life-cycle, but I agree that adding a life-cycle state is the most clean.

Thank you!  I am glad we are on the same wavelength, @kleopatra .
Could we get this PR approved?  Do you think we should expand the Skin javadoc?

-------------

PR: https://git.openjdk.org/jfx/pull/845