RFR: 8290844: Add Skin.install() method [v4]
Kevin Rushforth
kcr at openjdk.org
Tue Sep 6 15:31:52 UTC 2022
On Tue, 6 Sep 2022 15:06:44 GMT, Andy Goryachev <angorya at openjdk.org> wrote:
> Could we get this PR approved?
The PR isn't ready to be approved, but the API changes and javadoc are ready to be reviewed.
> Do you think we should expand the Skin javadoc?
Quite possibly. Related to this, I wonder whether we want to add an `@implNote` indicating that most implementations of Skin in the `javafx.controls` module do not implement `Skin::install` unless noted? I hesitate to document what is effectively an implementation detail, but sometimes that's what we use `@implNote` for in cases where a subclass might want to know.
-------------
PR: https://git.openjdk.org/jfx/pull/845
More information about the openjfx-dev
mailing list